-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mini-Challenge 4: State management #87
base: master
Are you sure you want to change the base?
Mini-Challenge 4: State management #87
Conversation
LuisRamirezHdz
commented
Aug 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good PR! Keep up the good work
a: '#fff', | ||
cardBodyHover: '#353434', | ||
}; | ||
const GlobalStyle = createGlobalStyle` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional:
Consider moving these styles to a separate file to keep App.component.jsx
tidier
@@ -0,0 +1,22 @@ | |||
import React, { useContext, useReducer } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional:
You can move all the places in which you have dispatch
to live inside this file.
You would then need to change value={[store, dispatch]}
to be something like value={{store, setSearchTerm, setTheme}}
that way you can use it like a normal function on the other files
@dianaatwizeline , |